Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add function to get memory context stats for processes - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Add function to get memory context stats for processes
Date
Msg-id CA+Tgmoaey-kOP1k5FaUnQFd1fR0majVebWcL8ogfLbG_nt-Ytg@mail.gmail.com
Whole thread Raw
Responses Re: pgsql: Add function to get memory context stats for processes
List pgsql-hackers
Tree view 
On Tue, Apr 8, 2025 at 5:10 AM Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:
> Add function to get memory context stats for processes

Apologies if this has already been discussed, but what is the argument
that it is safe to do everything in ProcessGetMemoryContextInterrupt()
at an arbitrary CHECK_FOR_INTERRUPTS() call? We have
CHECK_FOR_INTERRUPTS() calls in some quite low-level places, such as
walkdir() and copydir(). I don't think there's any guarantee that it's
safe to perform DSA operations at an arbitrary place where
CHECK_FOR_INTERRUPTS() is called, and I'm not even quite sure that
it's safe to assume that the local memory-context tree is in a
consistent state when CHECK_FOR_INTERRUPTS() is called. If there is
some existing discussion of this that I should read, please point me
in the right direction; I didn't see anything in a quick look through
the commit.

Thanks,

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Add os_page_num to pg_buffercache
Next
From: Tomas Vondra
Date:
Subject: Re: Add os_page_num to pg_buffercache