Re: when the startup process doesn't (logging startup delays) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: when the startup process doesn't (logging startup delays)
Date
Msg-id CA+TgmoabzuDusgH6Mp-b+znfrHCdsrbAv2H1=zPsDf2gYvGsRA@mail.gmail.com
Whole thread Raw
In response to Re: when the startup process doesn't (logging startup delays)  (Nitin Jadhav <nitinjadhavpostgres@gmail.com>)
Responses Re: when the startup process doesn't (logging startup delays)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Fri, Oct 29, 2021 at 9:10 AM Nitin Jadhav
<nitinjadhavpostgres@gmail.com> wrote:
> > I think you're wrong. If we did that, the previous timer could fire
> > right after we set startup_progress_timer_expired = false, and before
> > we reschedule the timeout. It seems annoying to have to disable the
> > timeout and immediately turn around and re-enable it, but I don't see
> > how to avoid the race condition otherwise.
>
> Right. There is a possibility of race conditions. In that case the
> above changes look good to me.

Committed.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Add support for ALTER INDEX .. ALTER [COLUMN] col_num {SET, RESET}
Next
From: Bharath Rupireddy
Date:
Subject: add checkpoint stats of snapshot and mapping files of pg_logical dir