Re: C99 compliance for src/port/snprintf.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: C99 compliance for src/port/snprintf.c
Date
Msg-id CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com
Whole thread Raw
In response to C99 compliance for src/port/snprintf.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: C99 compliance for src/port/snprintf.c
Re: C99 compliance for src/port/snprintf.c
List pgsql-hackers
On Tue, Aug 14, 2018 at 7:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I'm almost tempted to think that the reasons above make this a
> back-patchable bug fix.  Comments?

No objections to changing the behavior.  Have you checked whether
there are any noticeable performance consequences?

Back-patching seems a bit aggressive to me considering that the danger
is hypothetical.  I'd want to have some tangible evidence that
back-patching was going help somebody. For all we know somebody's got
an extension which they only use on Windows that happens to be relying
on the current behavior, although more likely still (IMHO) is that it
there is little or no code relying on either behavior.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: libpq should append auth failures, not overwrite
Next
From: Robert Haas
Date:
Subject: Re: Facility for detecting insecure object naming