Postgres Pro
Downloads
Home   >   mailing lists

Re: Bug in abbreviated keys abort handling (found with amcheck) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Bug in abbreviated keys abort handling (found with amcheck)
Date
Msg-id CA+TgmoaafJc6oLzy4H0zr1C+tb8VrVTsQfJh2BFQzS9=2GdDnw@mail.gmail.com
Whole thread Raw
In response to Bug in abbreviated keys abort handling (found with amcheck)  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Bug in abbreviated keys abort handling (found with amcheck)
List pgsql-hackers
Tree view 
On Fri, Aug 19, 2016 at 6:07 PM, Peter Geoghegan <pg@heroku.com> wrote:
> I found another bug as a result of using amcheck on Heroku customer
> databases. This time, the bug is in core Postgres. It's one of mine.
>
> There was a thinko in tuplesort's abbreviation abort logic, causing
> certain SortTuples to be spuriously marked NULL (and so, subsequently
> sorted as a NULL tuple, despite not actually changing anything about
> the representation of caller tuples). The attached patch fixes this
> bug.

Ugh, that sucks. Thanks for the report and patch.  Committed and
back-patched to 9.5.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Changed SRF in targetlist handling
Next
From: Tom Lane
Date:
Subject: Re: Changed SRF in targetlist handling