Re: pgsql: Add 'basebackup_to_shell' contrib module. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date
Msg-id CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add 'basebackup_to_shell' contrib module.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Add 'basebackup_to_shell' contrib module.
List pgsql-hackers
On Wed, Mar 30, 2022 at 12:30 PM Andres Freund <andres@anarazel.de> wrote:
> # Reconfigure to restrict access and require a detail.
> $shell_command =
>         $PostgreSQL::Test::Utils::windows_os
>         ? qq{$gzip --fast > "$escaped_backup_path\\\\%d.%f.gz"}
>     : qq{$gzip --fast > "$escaped_backup_path/%d.%f.gz"};
>
> I don't think the branch is needed anymore, forward slashes should work for
> output redirection.

We have similar things in src/test/perl/PostgreSQL/Test/Cluster.pm. Do
you think those can also be removed? I'm not sure it's the place of
this patch to introduce a mix of styles.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.