Re: [HACKERS] Proposal: Improve bitmap costing for lossy pages - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Proposal: Improve bitmap costing for lossy pages
Date
Msg-id CA+TgmoaYBUSf2iuJBNXM8Tm-=cTAUV112EziXp6iOG2Z9MC--w@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Proposal: Improve bitmap costing for lossy pages  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: [HACKERS] Proposal: Improve bitmap costing for lossy pages
List pgsql-hackers
On Fri, Oct 6, 2017 at 2:12 AM, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>> The performance results look good, but that's a slightly different
>> thing from whether the estimate is accurate.
>>
>> +    nbuckets = tbm_calculate_entires(maxbytes);
>>
>> entires?
>
> changed to
> + tbm->maxentries = (int) tbm_calculate_entires(maxbytes);

My point was not that you should add a cast, but that you wrote
"entires" rather than "entries".

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] parallel worker (PID ) exited with exit code 1
Next
From: Bernd Helmle
Date:
Subject: Re: [HACKERS] parallel worker (PID ) exited with exit code 1