[HACKERS] compiler warning in set_tablefunc_size_estimates - Mailing list pgsql-hackers

From Robert Haas
Subject [HACKERS] compiler warning in set_tablefunc_size_estimates
Date
Msg-id CA+TgmoaWP9qN1mWhu1uwtt6mTEPfjL734Apru2iVMKFjYKNuHQ@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] compiler warning in set_tablefunc_size_estimates  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I tried a non-cassert compile on a machine that has a pickier compiler
than my laptop, and got:

costsize.c: In function ‘set_tablefunc_size_estimates’:
costsize.c:4574:17: error: variable ‘rte’ set but not used
[-Werror=unused-but-set-variable]

That appears to be a legitimate gripe.  Perhaps:

diff --git a/src/backend/optimizer/path/costsize.c
b/src/backend/optimizer/path/costsize.c
index e78f3a8..c23f681 100644
--- a/src/backend/optimizer/path/costsize.c
+++ b/src/backend/optimizer/path/costsize.c
@@ -4571,12 +4571,9 @@ set_function_size_estimates(PlannerInfo *root,
RelOptInfo *rel)voidset_tablefunc_size_estimates(PlannerInfo *root, RelOptInfo *rel){
-       RangeTblEntry *rte;
-       /* Should only be applied to base relations that are functions */       Assert(rel->relid > 0);
-       rte = planner_rt_fetch(rel->relid, root);
-       Assert(rte->rtekind == RTE_TABLEFUNC);
+       Assert(planner_rt_fetch(rel->relid, root)->rtekind == RTE_TABLEFUNC);
       rel->tuples = 100;

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: [HACKERS] alter enum add value regression
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] WIP: [[Parallel] Shared] Hash