Re: logical changeset generation v6.8 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: logical changeset generation v6.8
Date
Msg-id CA+TgmoaNu5Msp7o_fxHqSEGoL1vCb_h6mHok85mjsSOb8NsCEw@mail.gmail.com
Whole thread Raw
In response to Re: logical changeset generation v6.8  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Wed, Dec 11, 2013 at 11:25 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2013-12-10 19:11:03 -0500, Robert Haas wrote:
>> Committed #1 (again).  Regarding this:
>>
>> +       /* XXX: we could also do this unconditionally, the space is used anyway
>> +       if (copy_oid)
>> +               HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp));
>>
>> I would like to put in a big +1 for doing that unconditionally.  I
>> didn't make that change before committing, but I think it'd be a very
>> good idea.
>
> Patch attached.

Committed with kibitzing.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: Time-Delayed Standbys
Next
From: Robert Haas
Date:
Subject: Re: -d option for pg_isready is broken