Re: [HACKERS] path toward faster partition pruning - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] path toward faster partition pruning
Date
Msg-id CA+TgmoaFppRnEKp_zjM3ARkRt3EuQR7NiycYqAyzxhEPOf3dpA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] path toward faster partition pruning  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] path toward faster partition pruning
List pgsql-hackers
On Tue, Feb 6, 2018 at 4:55 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> I understand why COLLATION_MATCH think that a collation OID match is
>> OK, but why is InvalidOid also OK?  Can you add a comment?  Maybe some
>> test cases, too?
>
> partcollid == InvalidOid means the partition key is of uncollatable type,
> so further checking the collation is unnecessary.

Yeah, but in that case wouldn't BOTH OIDs be InvalidOid, and thus the
equality test would mach anyway?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Temporary tables prevent autovacuum, leading to XID wraparound
Next
From: Peter Eisentraut
Date:
Subject: Re: Cancelling parallel query leads to segfault