Re: alter table only ... drop constraint broken in HEAD - Mailing list pgsql-hackers

From Robert Haas
Subject Re: alter table only ... drop constraint broken in HEAD
Date
Msg-id CA+TgmoaEq=bkbirOKcCqbGLv200VA+sp9GaiX1aNaHRZLNMCyA@mail.gmail.com
Whole thread Raw
In response to alter table only ... drop constraint broken in HEAD  (Alex Hunsaker <badalex@gmail.com>)
Responses Re: alter table only ... drop constraint broken in HEAD  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Oct 5, 2011 at 5:53 PM, Alex Hunsaker <badalex@gmail.com> wrote:
> tldr:
>
> Seems to be broken by
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4da99ea4231e3d8bbf28b666748c1028e7b7d665
> :
> commit 4da99ea4231e3d8bbf28b666748c1028e7b7d665
> Author: Robert Haas <rhaas@postgresql.org>
> Date:   Mon Jun 27 10:27:17 2011 -0400
>
>    Avoid having two copies of the HOT-chain search logic.

Hmm... that's pretty terrible.  Yikes.  That commit wasn't intended to
change any behavior, just to clean up the code, so I think the right
thing to do here is figure out how I changed the behavior without
meaning too, rather than to start patching up all the places that
might have been affected by whatever the behavior change was.  I'm too
tired to figure this out right now, but I'll spend some time staring
at it tomorrow.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)
Next
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.