Re: tablespace_map code cleanup - Mailing list pgsql-hackers

From Robert Haas
Subject Re: tablespace_map code cleanup
Date
Msg-id CA+TgmoaABG5_BmocBEuFbtmi1xk9Bw0sW_wO3V-v3KKZfAp8gw@mail.gmail.com
Whole thread Raw
In response to Re: tablespace_map code cleanup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: tablespace_map code cleanup  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Wed, May 6, 2020 at 11:15 AM Robert Haas <robertmhaas@gmail.com> wrote:
> Oh, good point. v2 attached.

Here's v3, with one more small cleanup. I noticed tblspc_map_file is
initialized to NULL and then unconditionally reset to the return value
of makeStringInfo(), and then later tested to see whether it is NULL.
It can't be, because makeStringInfo() doesn't return NULL. So the
attached version deletes the superfluous initialization and the
superfluous test.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: PG 13 release notes, first draft
Next
From: Peter Geoghegan
Date:
Subject: Re: Should smgrdounlink() be removed?