Re: PageIsAllVisible()'s trustworthiness in Hot Standby - Mailing list pgsql-hackers

From Robert Haas
Subject Re: PageIsAllVisible()'s trustworthiness in Hot Standby
Date
Msg-id CA+Tgmoa=9twuTokXs9hFwCbR51GMeMKfX4ikNKJJa5CxSzYScw@mail.gmail.com
Whole thread Raw
In response to Re: PageIsAllVisible()'s trustworthiness in Hot Standby  (Pavan Deolasee <pavan.deolasee@gmail.com>)
List pgsql-hackers
On Wed, Dec 12, 2012 at 12:31 PM, Pavan Deolasee
<pavan.deolasee@gmail.com> wrote:
> On Wed, Dec 12, 2012 at 1:35 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Tue, Dec 4, 2012 at 12:10 PM, Pavan Deolasee
>> <pavan.deolasee@gmail.com> wrote:
>>> Hmm. Yeah, I do not have guts to prove that either. I'll probably write up a
>>> comment for your consideration to explain why we don't trust PD_ALL_VISIBLE
>>> in Hot standby for seq scans, but still trust VM for index-only scans.
>>
>> Sure.
>>
>
> Here is a small patch that adds comments to heap scan code explaining
> why we don't trust the all-visible flag in the page, still continue to
> support index-only scans on hot standby.

Committed, with a few modifications to the last part.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: bulk_multi_insert infinite loops with large rows and small fill factors
Next
From: Dimitri Fontaine
Date:
Subject: Re: Use of systable_beginscan_ordered in event trigger patch