GetTupleForTrigger could use a header comment - Mailing list pgsql-hackers

From Robert Haas
Subject GetTupleForTrigger could use a header comment
Date
Msg-id CA+Tgmoa1z+53RAvT573G4+dS0o5Q5pRPP0P64G3z9sYYyX4igg@mail.gmail.com
Whole thread Raw
List pgsql-hackers
GetTupleForTrigger seems to be a fairly important part of the trigger
machinery, yet it has no header comment.  I think it should, although
I don't understand it well enough at this point to write one.  Right
now, one is left to guess at the overall purpose of the function and
the meanings of the arguments.  For example, it does something very
different based on whether newSlot != NULL, with zero explanation as
to the underlying reasons or theory of operation.  Whee!

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: pgsql: Disable installcheck tests for test_session_hooks
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf