Re: recent ALTER whatever .. SET SCHEMA refactoring - Mailing list pgsql-hackers

From Robert Haas
Subject Re: recent ALTER whatever .. SET SCHEMA refactoring
Date
Msg-id CA+Tgmoa0hVTu31nqU2s+Pz-6WtrGd2rZaGRgzFzk+vquDRpejg@mail.gmail.com
Whole thread Raw
In response to Re: recent ALTER whatever .. SET SCHEMA refactoring  (Kohei KaiGai <kaigai@kaigai.gr.jp>)
Responses Re: recent ALTER whatever .. SET SCHEMA refactoring
List pgsql-hackers
On Tue, Jan 8, 2013 at 4:05 AM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
> Does it make sense an idea to invoke AlterFunctionNamespace_oid()
> or AlterCollationNamespace_oid() from AlterObjectNamespace_internal()
> for checks of namespace conflicts?
> It can handle special cases with keeping modularity between common
> and specific parts. Let's consider function pointer when we have mode
> than 5 object classes that needs special treatment.

Unless I'm gravely mistaken, we're only talking about a handful of
lines of code.  We have lots of functions, in objectaddress.c for
example, whose behavior is conditional on the type of object that they
are operating on.  And we just write out all the cases.  I'm not
understanding why we need to take a substantially more complex
approach here.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: Improve compression speeds in pg_lzcompress.c
Next
From: Robert Haas
Date:
Subject: Re: Improve compression speeds in pg_lzcompress.c