Re: cleaning perl code - Mailing list pgsql-hackers

From Robert Haas
Subject Re: cleaning perl code
Date
Msg-id CA+Tgmoa0VjL+qmrJakQKA8+eyBNopVz=vBEDe9Sh3Hpp+-e6_g@mail.gmail.com
Whole thread Raw
In response to cleaning perl code  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: cleaning perl code
List pgsql-hackers
On Thu, Apr 9, 2020 at 11:44 AM Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> We currently only run perlcritic at severity level 5, which is fairly
> permissive. I'd like to reduce that, ideally to, say, level 3, which is
> what I use for the buildfarm code.
>
> But let's start by going to severity level 4.

I continue to be skeptical of perlcritic. I think it complains about a
lot of things which don't matter very much. We should consider whether
the effort it takes to keep it warning-clean has proportionate
benefits.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Parallel copy
Next
From: Tim Bishop
Date:
Subject: Re: debian bugrept involving fast default crash in pg11.7