On Fri, Jul 12, 2013 at 9:15 AM, Amit kapila <amit.kapila@huawei.com> wrote:
> The sleep is used to ensure the effects of pg_reload_conf() can be visible.
That strikes me as almost certain to result in random regression test
failures. My experience, as a man who helps to maintain a very large
suite of regression tests, is that all time-based assumptions about
how long it will take some operation to complete are false, and that
failures are a lot more frequent than you think they will be.
This feature doesn't strike me as a good candidate for regression
testing anyway. Keep in mind that people are intended to be able to
run make installcheck against a deployed system without messing it up.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
