Re: Atomic operations within spinlocks - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Atomic operations within spinlocks
Date
Msg-id CA+TgmoZwihdVft1vehsgP-nG_s8pd+FvtfdMcqDMK_AXqSwdhg@mail.gmail.com
Whole thread Raw
In response to Re: Atomic operations within spinlocks  (Andres Freund <andres@anarazel.de>)
Responses Re: Atomic operations within spinlocks  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Atomic operations within spinlocks  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Jun 5, 2020 at 8:19 PM Andres Freund <andres@anarazel.de> wrote:
> Randomly noticed while looking at the code:
>         uint64          flagbit = UINT64CONST(1) << (uint64) type;
>
> that shouldn't be 64bit, right?

I'm going to admit ignorance here. What's the proper coding rule?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: FailedAssertion at ReorderBufferCheckMemoryLimit()
Next
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions