Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To: - Mailing list pgsql-hackers

On Thu, May 12, 2022 at 10:20 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> As for skink failing, the timeout was hard coded 300s for the whole
> test, but apparently that wasn't enough under valgrind.  Let's use the
> standard PostgreSQL::Test::Utils::timeout_default (180s usually), but
> reset it for each query we send.

@@ -202,6 +198,9 @@ sub send_query_and_wait
  my ($psql, $query, $untl) = @_;
  my $ret;

+ $psql_timeout->reset();
+ $psql_timeout->start();
+
  # send query
  $$psql{stdin} .= $query;
  $$psql{stdin} .= "\n";

This seems fine, but I think you should add a non-trivial comment about it.

-- 
Robert Haas
EDB: http://www.enterprisedb.com