Re: Why does contain_leaked_vars believe MinMaxExpr is safe? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Why does contain_leaked_vars believe MinMaxExpr is safe?
Date
Msg-id CA+TgmoZn74=oGfxL-0aCH35hnFxv1N6vVn15kH5Evy2XNDguGQ@mail.gmail.com
Whole thread Raw
In response to Why does contain_leaked_vars believe MinMaxExpr is safe?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Why does contain_leaked_vars believe MinMaxExpr is safe?  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Tue, May 12, 2015 at 7:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> MinMaxExpr is an implicit invocation of a btree comparison function.
> Are we supposing that all of those are necessarily leakproof?

I suspect it's an oversight, because the comment gives no hint that
any such intention was present.  It's been more than three years since
I committed that code (under a different function name) so my memory
is a little fuzzy, but I believe it just didn't occur to me that
MinMaxExpr could include a function call.

I suspect it's safe in practice, but in theory it's probably a bug.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Streaming replication and WAL archive interactions
Next
From: Petr Jelinek
Date:
Subject: Re: Sequence Access Method WIP