Postgres Pro
Downloads
Home   >   mailing lists

Re: Unify drop-by-OID functions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Unify drop-by-OID functions
Date
Msg-id CA+TgmoZn1t2+wUabUHK0=kxLHvQHL6QVnBCBSA+3mZcmgC10Hg@mail.gmail.com
Whole thread Raw
In response to Re: Unify drop-by-OID functions  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Unify drop-by-OID functions
List pgsql-hackers
Tree view 
On Fri, May 1, 2020 at 10:51 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> +1

+1 from me, too, but I have a few suggestions:

+DropGenericById(const ObjectAddress *object)

How about "Generic" -> "Object" or "Generic" -> "ObjectAddress"?

+ elog(ERROR, "cache lookup failed for %s entry %u",
+ elog(ERROR, "could not find tuple for class %u entry %u",

How about "entry" -> "with OID"?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: James Coleman
Date:
Subject: Re: pg_rewind docs correction