Re: [HACKERS] [PATCH] Change missleading comment for tm_mon field ofpg_tm structure - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] [PATCH] Change missleading comment for tm_mon field ofpg_tm structure
Date
Msg-id CA+TgmoZbfNQew5t0_qw3MFYsYs3oDq=O6aMCiUNbQKYnrCDFtQ@mail.gmail.com
Whole thread Raw
In response to [HACKERS] [PATCH] Change missleading comment for tm_mon field of pg_tm structure  (Dmitry Fedin <dmitry.fedin@gmail.com>)
List pgsql-hackers
On Thu, Jan 19, 2017 at 2:52 PM, Dmitry Fedin <dmitry.fedin@gmail.com> wrote:
> According to usages, tm_mon (month) field has origin 1, not 0. This is
> difference from C-library version of struct tm, which has origin 0 for
> real.

Hmm, thanks for noticing.  Looks like it has been wrong for a really long time.

Your patch got garbled; it had two-space indents instead of tabs, so
it didn't apply.  It's best to attach them rather than including them
inline.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Nikhil Sontakke
Date:
Subject: Re: [HACKERS] Speedup twophase transactions
Next
From: Konstantin Knizhnik
Date:
Subject: [HACKERS] Deadlock in XLogInsert at AIX