On Mon, Mar 18, 2013 at 4:42 PM, Kevin Grittner <kgrittn@ymail.com> wrote:
> I want to give everyone else a chance to weigh in before I start
> the pendulum swinging back in the other direction on OIDs in MVs.
> Opinions?
I agree that it's probably better to just disallow this, but I have to
admit I don't like your proposed patch much. It seems to me that the
right place to fix this is in interpretOidsOption(), by returning
false rather than default_with_oids whenever the relation is a
materialized view. That would require passing the relkind as an
additional argument to interpretOidsOption(), but that doesn't seem
problematic.
Then, the parser could just error out if OIDS=anything appears in the
options list, but it wouldn't need to actually kludge the options list
as you've done here.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
