Re: xlog location arithmetic - Mailing list pgsql-hackers

From Robert Haas
Subject Re: xlog location arithmetic
Date
Msg-id CA+TgmoZ_7hFNWp3sWqODLhB2qSz4ZnFKd3tw5UCbOFf6ZjSj3g@mail.gmail.com
Whole thread Raw
In response to Re: xlog location arithmetic  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: xlog location arithmetic
List pgsql-hackers
On Fri, Mar 9, 2012 at 9:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fujii@gmail.com> writes:
>> Euler proposed one more patch upthread, which replaces pg_size_pretty(bigint)
>> with pg_size_pretty(numeric) so that pg_size_pretty(pg_xlog_location_diff())
>> succeeds. It's also worth committing this patch?
>
> Why would it be useful to use pg_size_pretty on xlog locations?
> -1 because of the large expense of bigint->numeric->whatever conversion
> that would be added to existing uses.

The point is that it would be useful to use it on the difference
between two xlog locations, but that is a numeric value, not int8,
because of signedness issues.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: xlog location arithmetic
Next
From: Robert Haas
Date:
Subject: Re: Command Triggers, patch v11