Re: Fix comment in ATExecValidateConstraint - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Fix comment in ATExecValidateConstraint
Date
Msg-id CA+TgmoZXugh77M1tSVYZgSOE9U3TtzvKaCQYGwWYct-K0f0oJQ@mail.gmail.com
Whole thread Raw
In response to Fix comment in ATExecValidateConstraint  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: Fix comment in ATExecValidateConstraint  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Jul 25, 2016 at 4:18 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> The comment seems to have been copied from ATExecAddColumn, which says:
>
>  /*
>   * If we are told not to recurse, there had better not be any
> - * child tables; else the addition would put them out of step.
>
> For ATExecValidateConstraint, it should say something like:
>
> + * child tables; else validating the constraint would put them
> + * out of step.
>
> Attached patch fixes it.

I agree that the current comment is wrong, but what does "out of step"
actually mean here, anyway?  I think this isn't very clear.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Why we lost Uber as a user
Next
From: Bruce Momjian
Date:
Subject: Re: sslmode=require fallback