Re: Common function for percent placeholder replacement - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Common function for percent placeholder replacement
Date
Msg-id CA+TgmoZVDmePMVa1Muv-_UMdBB9-8__Onygu4Bg1+RyS4LFaMg@mail.gmail.com
Whole thread Raw
In response to Re: Common function for percent placeholder replacement  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On Mon, Dec 19, 2022 at 3:13 AM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
> I agree.  Here is an updated patch with the error checking included.

Nice, but I think something in the error report needs to indicate what
caused the problem exactly. As coded, I think the user would have to
guess which GUC caused the problem. For basebackup_to_shell that might
not be too hard since you would have to try to initiate a backup to a
shell target to trigger the error, but for something that happens at
server start, you don't want to have to go search all of
postgresql.conf for possible causes.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Error-safe user functions
Next
From: Tom Lane
Date:
Subject: Re: Error-safe user functions