Re: pg_combinebackup fails on file named INCREMENTAL.* - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_combinebackup fails on file named INCREMENTAL.*
Date
Msg-id CA+TgmoZU3DiJUupVKeZ2Zb-YgSGNhDSQ7esuHOaLjm-hSn1-Xw@mail.gmail.com
Whole thread Raw
In response to Re: pg_combinebackup fails on file named INCREMENTAL.*  (David Steele <david@pgmasters.net>)
Responses Re: pg_combinebackup fails on file named INCREMENTAL.*
List pgsql-hackers
On Mon, Apr 15, 2024 at 10:12 PM David Steele <david@pgmasters.net> wrote:
> Anyway, I think it should be fixed or documented as a caveat since it
> causes a hard failure on restore.

Alright, I'll look into this.

> I know Tomas added some optimizations that work best with --no-manifest
> but if we can eventually read compressed tars (which I expect to be the
> general case) then those optimizations are not very useful.

My belief is that those optimizations work fine with or without
manifests; you only start to lose the benefit in cases where you use
different checksum types for different backups that you then try to
combine. Which should hopefully be a rare case.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_combinebackup fails on file named INCREMENTAL.*
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Typos in the code and README