Re: pgsql: Fix a few problems in barrier.h. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Fix a few problems in barrier.h.
Date
Msg-id CA+TgmoZRowcAHDct7dLgVzerQBrm9JbWQ9Qwr1h7XmcUD-zdng@mail.gmail.com
Whole thread Raw
In response to pgsql: Fix a few problems in barrier.h.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix a few problems in barrier.h.  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pgsql: Fix a few problems in barrier.h.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Wed, Jul 17, 2013 at 6:39 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fix a few problems in barrier.h.
>
> On HPPA, implement pg_memory_barrier() as pg_compiler_barrier(), which
> should be correct since this arch doesn't do memory access reordering,
> and is anyway better than the completely-nonfunctional-on-this-arch
> dummy_spinlock code.  (But note this patch only fixes things for gcc,
> not for builds with HP's compiler.)

According to the comments in the barrier.h (and s_lock.h), HPPA is PA-RISC.

According to http://en.wikipedia.org/wiki/Memory_ordering, PA-RISC has
weak memory ordering.

So either this commit is wrong, or one of those things is wrong.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Remove tab from SGML file
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix a few problems in barrier.h.