Re: why does enum_endpoint call GetTransactionSnapshot()? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: why does enum_endpoint call GetTransactionSnapshot()?
Date
Msg-id CA+TgmoZL8CX4Sy++SnhLKnV2t5_kDv3U3s=UzpOpckyMNg9L9w@mail.gmail.com
Whole thread Raw
In response to Re: why does enum_endpoint call GetTransactionSnapshot()?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: why does enum_endpoint call GetTransactionSnapshot()?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> I think this is probably a holdover from before the death of
>> SnapshotNow, and that we should just pass NULL to
>> systable_beginscan_ordered() here, the same as we do for other catalog
>> accesses.  Barring objections, I'll go make that change.
>
> Seems reasonable to me, but why are you only looking at that one and
> not the identical code in enum_range_internal()?

I noticed that one after hitting send.  I think we should change them both.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: why does enum_endpoint call GetTransactionSnapshot()?
Next
From: Jim Nasby
Date:
Subject: Re: restrict global access to be readonly