Re: Command Triggers, patch v11 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Command Triggers, patch v11
Date
Msg-id CA+TgmoZKTfj3EMKow42mwt3zbfPN-V-bOJsExJ3avnezEceQkg@mail.gmail.com
Whole thread Raw
In response to Re: Command Triggers, patch v11  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Command Triggers, patch v11  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Mar 19, 2012 at 12:53 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On sön, 2012-03-18 at 21:16 -0400, Tom Lane wrote:
>> If we were going to change the output at all, I would vote for "CREATE
>> TABLE nnnn" so as to preserve the rowcount functionality.  Keep in
>> mind though that this would force client-side changes, for instance in
>> libpq's PQcmdTuples().  Fixing that one routine isn't so painful, but
>> what of other client-side libraries, not to mention applications?
>
> Doesn't seem worth it to me.  At least, "SELECT nnnn" makes some sense:
> nnnn rows were selected.  "CREATE TABLE nnnn" means what?  nnnn tables
> were created?
>
> What might make sense is to delegate this additional information to
> separate fields in a future protocol revision.

I think that we would not have bothered to add the row count to the
command tag output for SELECT unless it were useful.  It seems to be
*more* useful for CTAS than for SELECT; after all, SELECT also returns
the actual rows.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Command Triggers, patch v11
Next
From: Marco Nenciarini
Date:
Subject: Re: [PATCH] Support for foreign keys with arrays