Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line
Date
Msg-id CA+TgmoZHsb7z9ijtK1gs-QvFrRbmcw_7CnMzSGtrx=tY+47M-Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line  (David Christensen <david@endpoint.com>)
Responses Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line  (David Christensen <david@endpoint.com>)
List pgsql-hackers
On Thu, Oct 8, 2015 at 12:43 PM, David Christensen <david@endpoint.com> wrote:
> I’m happy to move it around, but If everything is in order, how will this affect things at all?  If we’re in a good
statethis condition should never trigger. 

Right, but I think it ought to be Catalog.pm's job to parse the config
file.  The job of complaining about what it contains is a job worth
doing, but it's not the same job.  Personally, I hate it when parsers
take it upon themselves to do semantic analysis, because then what
happens if you want to write, say, a tool to repair a broken file?
You need to be able to read it in without erroring out so that you can
frob whatever's busted and write it back out, and the parser is
getting in your way.  Maybe that's not going to come up here, but I'm
just explaining my general philosophy on these things...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::')
Next
From: Robert Haas
Date:
Subject: Re: Freeze avoidance of very large table.