Re: proposal: alternative psql commands quit and exit - Mailing list pgsql-hackers

From Robert Haas
Subject Re: proposal: alternative psql commands quit and exit
Date
Msg-id CA+TgmoZG6-LxMMu4si4GuJnYvKXJKBrthe2DEXsCQW4uYRwmkQ@mail.gmail.com
Whole thread Raw
In response to Re: proposal: alternative psql commands quit and exit  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: proposal: alternative psql commands quit and exit
Re: proposal: alternative psql commands quit and exit
Re: proposal: alternative psql commands quit and exit
Re: proposal: alternative psql commands quit and exit
List pgsql-hackers
On Mon, Jan 15, 2018 at 10:57 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> I've discovered one thing about this design that is not so good, which
>> is that if you open a single, double, or dollar quote, then the
>> instructions that are provided under that design do not work:
>
> I was kind of imagining that we could make the hint text vary depending
> on the parsing state.  Maybe that's too hard to get to --- but if the
> prompt-creating code knows what it is, perhaps this can too.

prompt_status does seem to be available in psql's MainLoop(), so I
think that could be done, but the problem is that I don't know exactly
what message would be useful to print when we're in a "in quotes"
state.  If I had a good message text for that state, I might just
choose to use it always rather than multiplying the number of
messages.

More broadly, I think what is needed here is less C-fu than
English-fu.  If we come up with something good, we can make it print
that thing.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: proposal: alternative psql commands quit and exit
Next
From: Geoff Winkless
Date:
Subject: Re: proposal: alternative psql commands quit and exit