Re: buffer locking fix for lazy_scan_heap - Mailing list pgsql-hackers

From Robert Haas
Subject Re: buffer locking fix for lazy_scan_heap
Date
Msg-id CA+TgmoZFZhVbwzsYganayJjSiiJK-0TQE2gEvT+NUYJYGCi1_Q@mail.gmail.com
Whole thread Raw
In response to Re: buffer locking fix for lazy_scan_heap  (高增琦 <pgf00a@gmail.com>)
List pgsql-hackers
On Mon, Aug 3, 2015 at 12:03 AM, 高增琦 <pgf00a@gmail.com> wrote:
> sorry for asking this really old commit.
>
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7ab9b2f3b79177e501a1ef90ed004cc68788abaf
>
> I could not understand why "releases the lock on the buffer" is
> a problem since vacuum will lock and check the page bit again before
> set the vm. Did I missed something?

Hmm, you might be right.  It certainly seems safer to do all the work
without releasing the buffer lock temporarily in the middle, but maybe
the old way wasn't actually broken.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );
Next
From: Amit Kapila
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file