On Mon, Jan 17, 2022 at 1:06 PM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> > On Jan 15, 2022, at 12:28 AM, Julien Rouhaud <rjuju123@gmail.com> wrote:
> > Could you send a rebased version?
> Yes. Here it is:
This is not a full review, but I just noticed that:
+ * dotcnt: how many separators were parsed from the pattern, by reference.
+ * Can be NULL.
But then:
+ Assert(dotcnt != NULL);
On a related note, it's unclear why you've added three new arguments
to processSQLNamePattern() but only one of them gets a mention in the
function header comment.
It's also pretty clear that the behavior of patternToSQLRegex() is
changing, but the function header comments are not.
--
Robert Haas
EDB: http://www.enterprisedb.com
