Re: Add missing PGDLLIMPORT markings - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Add missing PGDLLIMPORT markings
Date
Msg-id CA+TgmoZCDVK4hk+XB6Qv67xsnCVxTy9frwb8a5CLLw-8eOVXEA@mail.gmail.com
Whole thread Raw
In response to Re: Add missing PGDLLIMPORT markings  (Andres Freund <andres@anarazel.de>)
Responses Re: Add missing PGDLLIMPORT markings
List pgsql-hackers
On Wed, Apr 9, 2025 at 11:28 AM Andres Freund <andres@anarazel.de> wrote:
> FWIW, the AIO ones really don't make sense to make public - the only reason
> for those variables to exists is so they can be put into an array of
> callbacks. There's no way an extension could ever benefit from them.  But I
> guess we don't really have a way to tell mark_pgdllimport.pl that.

I'm not here to say that you're wrong, but this kind of argument is
exactly why we didn't use to mark a bunch of things PGDLLIMPORT that,
as it turned out, extension developers actually wanted to use.

I don't think we should go back to the bad old days where we litigated
every case of marking something PGDLLIMPORT or not unless we have an
extremely good reason for so doing.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: n_ins_since_vacuum stats for aborted transactions
Next
From: Nathan Bossart
Date:
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects