Re: backup manifests - Mailing list pgsql-hackers

From Robert Haas
Subject Re: backup manifests
Date
Msg-id CA+TgmoZBrwYvfQ=ymXk669+hgdQxpoypQVYdWiGwpOE_yuMW4A@mail.gmail.com
Whole thread Raw
In response to Re: backup manifests  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: backup manifests  (Stephen Frost <sfrost@snowman.net>)
Re: backup manifests  (Amit Kapila <amit.kapila16@gmail.com>)
Re: backup manifests  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, Mar 23, 2020 at 7:04 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> /src/bin/pg_validatebackup/tmp_check/t_002_algorithm_master_data/backup/none
> --manifest-checksum none --no-sync
> \tmp_install\bin\pg_basebackup.EXE: illegal option -- manifest-checksum
>
> It seems the option to be used should be --manifest-checksums.  The
> attached patch fixes this problem for me.

OK, incorporated that.

> > t/002_algorithm.pl ..... 4/19 #   Failed test 'validate backup with
> > algorithm "none"'
> > #   at t/002_algorithm.pl line 53.
> >
>
> The error message for the above failure is:
> pg_validatebackup: fatal: could not parse backup manifest: both
> pathname and encoded pathname
>
> I don't know at this stage what could cause this?  Any pointers?

I think I forgot an initializer. Try this version.

I also incorporated a fix previously proposed by Suraj for the
compiler warning you mentioned in the other email.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: some AppVeyor files
Next
From: Alexander Korotkov
Date:
Subject: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line