Postgres Pro
Downloads
Home   >   mailing lists

Re: "page is not marked all-visible" warning in regression tests - Mailing list pgsql-hackers

From Robert Haas
Subject Re: "page is not marked all-visible" warning in regression tests
Date
Msg-id CA+TgmoZ9hNFwVzWJOcEwoGbqEmAgFk4bnj86DBzRrGhy07Hvbw@mail.gmail.com
Whole thread Raw
In response to Re: "page is not marked all-visible" warning in regression tests  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: "page is not marked all-visible" warning in regression tests  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Thu, Jun 7, 2012 at 12:19 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> You could do a visibilitymap_pin outside, but I don't really see the point as
> the page is already locked. There might be some slight benefit in doing so in
> multi_insert but that would be more complicated. And of doubtful benefit.

Doesn't RelationGetBufferForTuple() already do exactly that?

>> Updated patch attached.
> Looks good.

Thanks for the review.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Ability to listen on two unix sockets
Next
From: Simon Riggs
Date:
Subject: Re: slow dropping of tables, DropRelFileNodeBuffers, tas