Re: [HACKERS] Create language syntax is not proper in pg_dumpall andnot working using pg_upgrade - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Create language syntax is not proper in pg_dumpall andnot working using pg_upgrade
Date
Msg-id CA+TgmoZ4ob1fB4BEm1NJD=RdnBVbGzCeKj5tVzoHPpSWBF7fZw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Jul 25, 2017 at 1:50 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
>> I'm not sure what you're arguing for here.
>
> Robert wants perfection, of course ;-).  As do we all.  But there are
> only so many hours in the day, and rejiggering pg_dump's rules about
> how to dump PLs is just way down the to-do list.  I'm going to go do
> something with more tangible benefit, like see if we can make its
> REFRESH MATERIALIZED VIEW commands come out at the right time.

+1 to all of that.  I'm only arguing that there's a difference between
the things that are worth fixing and the things that are formally
bugs.  This may not be worth fixing, but I think it's formally a bug,
because you could easily expect it to work and there's no user-facing
documentation anywhere that says it doesn't.  However, I'm no doubt
about the relative priority of this vs. the other issue you mention.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] More race conditions in logical replication