Re: bgworker / SPI docs patches - Mailing list pgsql-docs

From Robert Haas
Subject Re: bgworker / SPI docs patches
Date
Msg-id CA+TgmoZ3Erhc7BSfE4T04KJNeQ-TNwP0X7OX94R0L+Vt7GYSLQ@mail.gmail.com
Whole thread Raw
In response to Re: bgworker / SPI docs patches  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-docs
On Thu, Jul 30, 2015 at 3:47 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Hmm. worker_spi module uses bgw_main. Is that bad? Given that work_spi is
> supposedly an example or template that you copy-paste from when writing your
> own bgworker, we should make sure it follows the best practice. Also, I note
> that worker_spi doesn't memset(0) its BackgroundWorker struct, so any
> uninitialized fields will contain garbage. Including bgw_library_name and
> bgw_function_name. That seems bad.

Yeah, that stuff is bad.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-docs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: bgworker / SPI docs patches
Next
From: Dmitry Igrishin
Date:
Subject: Confused by example in 13.2.2