Postgres Pro
Downloads
Home   >   mailing lists

Re: Custom table AMs need to include heapam.h because of BulkInsertState - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Custom table AMs need to include heapam.h because of BulkInsertState
Date
Msg-id CA+TgmoZ-p_tBSj2n2cQW33esqnQhA5oj4944dUM3hVo-UyHFaA@mail.gmail.com
Whole thread Raw
In response to Custom table AMs need to include heapam.h because of BulkInsertState  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Custom table AMs need to include heapam.h because ofBulkInsertState
List pgsql-hackers
Tree view 
On Sat, Jun 1, 2019 at 3:09 PM Michael Paquier <michael@paquier.xyz> wrote:
> I am fine to live with the dependency with vacuum.h as it is not that
> strange.  However for BulkInsertState we get a hard dependency with a
> heap-related area and it seems to me that we had better move that part
> out of heapam.c, as we want a clear dependency cut with the heap AM
> for any new custom table AM.

Yeah, I noticed this, too.  +1 for doing something about it.  Not sure
exactly what is the best approach.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Avoiding hash join batch explosions with extreme skew and weird stats
Next
From: Tom Lane
Date:
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)