Re: pg_stop_backup() v2 incorrectly marked as proretset - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_stop_backup() v2 incorrectly marked as proretset
Date
Msg-id CA+TgmoYyhGc_cxk8gqN=bi4+3sDeqzfEgxwSjzvVQ9xVsS1T=w@mail.gmail.com
Whole thread Raw
In response to Re: pg_stop_backup() v2 incorrectly marked as proretset  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_stop_backup() v2 incorrectly marked as proretset  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Mar 2, 2022 at 9:35 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Yeah, there's plenty of precedent for that coding if you look around.
> I've not read the whole patch, but this snippet seems fine to me
> if there's also an #undef at the end of the function.

From later emails, it sounds like that's not the common practice in
similar cases, and I don't personally see the point.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [Proposal] Global temporary tables
Next
From: Andres Freund
Date:
Subject: Re: casting operand to proper type in BlockIdGetBlockNumber