Re: fixing CREATEROLE - Mailing list pgsql-hackers

From Robert Haas
Subject Re: fixing CREATEROLE
Date
Msg-id CA+TgmoYq3VCEhKSH68WL++d=YFjq84DYz8etqVZ0gnEpJHpC_g@mail.gmail.com
Whole thread Raw
In response to Re: fixing CREATEROLE  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
On Wed, Apr 30, 2025 at 5:16 PM David G. Johnston
<david.g.johnston@gmail.com> wrote:
> On Wed, Apr 30, 2025 at 1:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> But don't we need to add
>>
>> createrole_self_grant to the set of GUCs that pg_dump[all]
>> resets in the emitted SQL?
>>
>
> The other approach would be to do what we do for the role options and just specify everything explicitly in the dump.
The GUC is only a default specifier so let's not leave room for defaults in the dump file. 

+1 for considering that option, although I am not sure which way is better.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture
Next
From: Tom Lane
Date:
Subject: Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture