Re: Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL
Date
Msg-id CA+TgmoYkNzH3W9e+PkY3TE5yOZfXqkYq7u4SjP_yaYuW80p6fg@mail.gmail.com
Whole thread Raw
In response to Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
On Tue, Sep 6, 2016 at 4:00 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> I'm also wondering why we don't use lock_timeout when the user sets it?
> Not a bug, but patch attached anyway.
> vacuum_truncate_use_lock_timeout.v1.patch

This part seems fairly random.  I don't think it makes sense to assume
that the timeout after which the user wants a lock acquisition request
to error out is the same time that they want as the interval between
retries.  Those things seem fairly thoroughly unconnected, and this
change could fairly easily cause truncation problems for people who
have the lock timeout set to a relatively long time (e.g. 10 minutes).

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Proposal for changes to recovery.conf API
Next
From: Robert Haas
Date:
Subject: Re: Declarative partitioning - another take