Re: Using defines for protocol characters - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Using defines for protocol characters
Date
Msg-id CA+TgmoYhA4Df2euFVK24NU9qkcHZBfbJTsr9M=4UWsr+sayD8Q@mail.gmail.com
Whole thread Raw
In response to Re: Using defines for protocol characters  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Using defines for protocol characters
List pgsql-hackers
On Mon, Aug 7, 2023 at 2:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> +1.  For ease of greppability, maybe even PQMSG_EmptyQueryResponse
> and so on?  Then one grep would find both uses of the constants and
> code/docs references.  Not sure if the prefix should be all-caps or
> not if we go this way.

PqMsgEmptyQueryResponse or something like that seems better, if we
want to keep the current capitalization. I'm not a huge fan of the way
we vary our capitalization conventions so much all over the code base,
but I think we would at least do well to keep it consistent from one
end of a certain identifier to the other.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Christoph Heiss
Date:
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
Next
From: Tomas Vondra
Date:
Subject: Re: Configurable FP_LOCK_SLOTS_PER_BACKEND