Postgres Pro
Downloads
Home   >   mailing lists

Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)" - Mailing list pgsql-hackers

From Robert Haas
Subject Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"
Date
Msg-id CA+TgmoY_aunsjo+jOEDc-p53Qvh7xxocccMiy8sy60ppPiyfXQ@mail.gmail.com
Whole thread Raw
In response to Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Tue, Jul 17, 2018 at 8:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Any objections?  Anyone want to do further review?

LGTM.  I think this is an improvement.  However, it seems like it
might be a good idea for ResourceOwnerRememberBuffer and
ResourceOwnerForgetBuffer to Assert(buffer != NULL), so that if
somebody messes up it will trip an assertion rather than just seg
faulting.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: "Write amplification" is made worse by "getting tired" whileinserting into nbtree secondary indexes (Was: Why B-Tree suffix truncation matters)
Next
From: Tom Lane
Date:
Subject: Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"