Re: Improving on MAX_CONVERSION_GROWTH - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Improving on MAX_CONVERSION_GROWTH
Date
Msg-id CA+TgmoY_3ZFbtUgnvrF2wAB-2hecdDuJjqEOM0T033XfE28wfg@mail.gmail.com
Whole thread Raw
In response to Re: Improving on MAX_CONVERSION_GROWTH  (Andres Freund <andres@anarazel.de>)
Responses Re: Improving on MAX_CONVERSION_GROWTH
List pgsql-hackers
On Fri, Sep 27, 2019 at 11:40 AM Andres Freund <andres@anarazel.de> wrote:
> Note that one of the additional reasons for the 1GB limit is that it
> protects against int overflows. I'm somewhat unconvinced that that's a
> sensible approach, but ...

It's not crazy. People using 'int' rather casually just as they use
'palloc' rather casually, without necessarily thinking about what
could go wrong at the edges. I don't have any beef with that as a
general strategy; I just think we should be trying to do better in the
cases where it negatively affects the user experience.

> It's worthwhile to note that additional passes over data are often quite
> expensive, memory latency hasn't shrunk that much in last decade or
> so. I have frequently seen all the memcpys from one StringInfo/char*
> into another StringInfo show up in profiles.

OK.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: fix "Success" error messages
Next
From: Fujii Masao
Date:
Subject: Re: Standby accepts recovery_target_timeline setting?