Re: aborting a non-speculative insertion - Mailing list pgsql-hackers

From Robert Haas
Subject Re: aborting a non-speculative insertion
Date
Msg-id CA+TgmoYZnq_XZWLjnxkbcEBg8OJRRNKqFuU_-ws_qcG3dEN=3w@mail.gmail.com
Whole thread Raw
In response to Re: aborting a non-speculative insertion  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Jun 11, 2019 at 12:06 PM Andres Freund <andres@anarazel.de> wrote:
> > This is relevant to my little project to make the TOAST logic reusable
> > by other AMs, because the comments in tableam.h suggest you can only
> > complete a speculative insertion if you've previously performed one.
> > If we allow any AM to be used to implement a TOAST table, then it
> > needs to be documented that such AMs have to cope with this kind of
> > case.
>
> Hm - you're thinking of making the case of toast AM and main AM being
> different working? I'm not sure I'd otherwise expect to again go through
> the AM, although I'm not sure about that.

I was, but I think we have the same requirement even if we don't,
because detoasting a datum from anywhere goes through a common code
path.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: aborting a non-speculative insertion
Next
From: Peter Geoghegan
Date:
Subject: Re: Status of the table access method work