On Sun, Nov 8, 2015 at 7:26 PM, Kouhei Kaigai <kaigai@ak.jp.nec.com> wrote:
> The attached patch is an adjusted version of the previous one.
> Even though it co-exists a new callback and fdw_recheck_quals,
> the callback is kicked first as follows.
This seems excessive to me: why would we need an arbitrary-length list
of plans for an FDW? I think we should just allow an outer child and
an inner child, which is probably one more than we'll ever need in
practice.
This looks like an independent bug fix:
+ fscan->fdw_recheck_quals = (List *)
+ fix_upper_expr(root,
+ (Node *)
fscan->fdw_recheck_quals,
+ itlist,
+ INDEX_VAR,
+ rtoffset); pfree(itlist);
If so, it should be committed separately and back-patched to 9.5.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
