Re: Removing GlobalVisTestNonRemovableHorizon - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Removing GlobalVisTestNonRemovableHorizon
Date
Msg-id CA+TgmoYWkX+AheFCnypOPn=yjSn2GW9MfcJL2ZpxuTEPXM4PNQ@mail.gmail.com
Whole thread Raw
In response to Removing GlobalVisTestNonRemovableHorizon  (Andres Freund <andres@anarazel.de>)
Responses Re: Removing GlobalVisTestNonRemovableHorizon
List pgsql-hackers
On Mon, Apr 15, 2024 at 2:57 PM Andres Freund <andres@anarazel.de> wrote:
> GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() only
> existed for snapshot_too_old - but that was removed in f691f5b80a8.  I'm
> inclined to think we should remove those functions for 17.  No new code should
> use them.

+1 for removing whatever people shouldn't be using. I recently spent a
lot of time looking at this code and it's quite complicated and hard
to understand. It would of course have been nice to have done this
sooner, but I don't think waiting for next release cycle will make
anything better.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: SET ROLE documentation improvement
Next
From: Pavel Borisov
Date:
Subject: Re: Table AM Interface Enhancements