Re: [sqlsmith] Failed assertions on parallel worker shutdown - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [sqlsmith] Failed assertions on parallel worker shutdown
Date
Msg-id CA+TgmoYTA_jDbiHQWFXnSTPs+MQSYwv76zeYCx7c0-UBAH2_oA@mail.gmail.com
Whole thread Raw
In response to Re: [sqlsmith] Failed assertions on parallel worker shutdown  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Sat, Jun 4, 2016 at 2:57 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> In the above change, you are first adding bytes_written and then doing the
> SHM_MQ_DETACHED check, whereas other place the check is done first which
> seems to be right.  I think it doesn't matter either way, but it is better
> to be consistent.  Also isn't it better to set mqh_length_word_complete as
> false as next time this API is called, it should first try to write length
> into buffer.

OK, committed after (I hope) fixing those issues.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Changed SRF in targetlist handling
Next
From: Tom Lane
Date:
Subject: Re: Changed SRF in targetlist handling