Re: Parallel Seq Scan vs kernel read ahead - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Parallel Seq Scan vs kernel read ahead
Date
Msg-id CA+TgmoYS6109DHMpa8VG=PmgX8UTSm=83RbCNtXr9G9j0A2paQ@mail.gmail.com
Whole thread Raw
In response to Re: Parallel Seq Scan vs kernel read ahead  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Parallel Seq Scan vs kernel read ahead  (Ranier Vilela <ranier.vf@gmail.com>)
Re: Parallel Seq Scan vs kernel read ahead  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Ranier,

This topic is largely unrelated to the current thread. Also...

On Mon, Jun 22, 2020 at 12:47 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
> Questions:
> 1. Why acquire and release lock in retry: loop.

This is a super-bad idea. Note the coding rule mentioned in spin.h.
There are many discussion on this mailing list about the importance of
keeping the critical section for a spinlock to a few instructions.
Calling another function that *itself acquires an LWLock* is
definitely not OK.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: Tom Lane
Date:
Subject: Re: More tzdb fun: POSIXRULES is being deprecated upstream